- Notifications
You must be signed in to change notification settings - Fork926
test: implement unit test to excercise pg connection deadlock#18556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
concurrency striking again 😭
| if o.returnSQLDB != nil { | ||
| o.returnSQLDB(sqlDB) | ||
| } | ||
| if o.dumpOnFailure { | ||
| t.Cleanup(func() { DumpOnFailure(t, connectionURL) }) | ||
| } | ||
| if o.maxConns > 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should it do something to unset the limit if you call it with0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The unit test code does not currently set a defaultMaxConns that I can tell. If we unset it with0, idk what to default it to 🤔.
I'm sure the package has some default we could revert to.
No description provided.