NotificationsYou must be signed in to change notification settings
Fork926
Star10.1k

chore: fix idle state icon when disabled#18554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

code-asher merged 1 commit intomainfromasher/disable-app-icon-fix

Jun 25, 2025

Merged

chore: fix idle state icon when disabled#18554

code-asher merged 1 commit intomainfromasher/disable-app-icon-fix

Jun 25, 2025

+44 −7

Conversation

Copy link

Member

code-asher commentedJun 24, 2025•
edited
Loading

When the workspace is off, we set a disabled text/stroke color, but for the idle icon that also needs a fill, this only changed the outline making it look weird. Instead, move the disabled logic into the component so we can apply a matching fill.

I felt it looked too thick with both the outline and fill, so I also removed the outline.

Really I think maybe the workspace status should be a separate column rather than disabling these icons, but this maintains the status quo.

Before with mismatching stroke and fill color:

After with disabled fill and stroke removal:

Enabled fill and stroke removal:

github-actionsbot assignedcode-asher

Jun 24, 2025

chore: fix idle state icon when disabled

27f64de

When the workspace is off, we set a disabled color, but for the idleicon that also needs a fill, this only changed the border making it lookweird.  Instead, move the disabled logic into the component so we canapply a matching fill when necessary.