NotificationsYou must be signed in to change notification settings
Fork925
Star10.1k

fix(enterprise/coderd/prebuilds): hard-limit preset if all create attempts failed#18551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

johnstcn wants to merge1 commit intomainfromcj/bail-multiple-failed-prebuilds

Closed

fix(enterprise/coderd/prebuilds): hard-limit preset if all create attempts failed#18551

johnstcn wants to merge1 commit intomainfromcj/bail-multiple-failed-prebuilds

+24 −1

Conversation

Copy link

Member

johnstcn commentedJun 24, 2025

A template was improperly configured for prebuilds, resulting in multiple logs spam.

The error was an unrecoverable one:

2025-06-24 18:06:22.492 | 2025-06-24 18:06:22.492 [erro]  coderd.prebuilds: failed to create prebuild  template_id=3e08934c-5661-4762-bfea-8efc0385002f  template_name=coder-with-amazon-q  template_version_id=e87ba734-afa1-45a3-96c7-9447a98c59db  template_version_name=epic_ishizaka8  preset_id=73912bb9-8fee-4833-bd8e-b8664db82edc  preset_name="GoLand ZA" ...     error= execute transaction:                github.com/coder/coder/v2/coderd/database.(*sqlQuerier).runTx                    /home/runner/work/coder/coder/coderd/database/db.go:213              - provision workspace:                github.com/coder/coder/v2/enterprise/coderd/prebuilds.(*StoreReconciler).provision                    /home/runner/work/coder/coder/enterprise/coderd/prebuilds/reconcile.go:745              - build tx:                github.com/coder/coder/v2/coderd/wsbuilder.(*Builder).Build                    /home/runner/work/coder/coder/coderd/wsbuilder/wsbuilder.go:285              - execute transaction:                github.com/coder/coder/v2/coderd/database.(*sqlQuerier).runTx                   /home/runner/work/coder/coder/coderd/database/db.go:193              - get parameters:                github.com/coder/coder/v2/coderd/wsbuilder.(*Builder).getParameters                    /home/runner/work/coder/coder/coderd/wsbuilder/wsbuilder.go:720              - Parameter "AI Prompt" is required but not provided

As far as I can tell, ifcreatePrebuiltWorkspace() fails all of the times it attempted to create a prebuild, it is unlikely to ever succeed for that preset.

Still TODO: figure out how to write a test for this.