- Notifications
You must be signed in to change notification settings - Fork925
fix(agent/agentcontainers): remove shellquote in favor of %q#18544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
mafredri merged 2 commits intomainfrommafredri/fix-agent-agentcontainers-commandEnvExecerJun 24, 2025
Merged
fix(agent/agentcontainers): remove shellquote in favor of %q#18544
mafredri merged 2 commits intomainfrommafredri/fix-agent-agentcontainers-commandEnvExecerJun 24, 2025
+8 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
DanielleMaywood requested changesJun 24, 2025
Uh oh!
There was an error while loading.Please reload this page.
Shellquote modified `{{.Name}}` to `\{\{.Name}}` breaking Fish, byswitching to quoting each arg individually we should have a moreportable (across shells) implementation.5de812f to13c3134CompareDanielleMaywood approved these changesJun 24, 2025
96f10e1 tod09fc11Compare64a2214 intomain 36 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shellquote modified
{{.Name}}to\{\{.Name}}breaking Fish, byswitching to quoting each arg individually we should have a more
portable (across shells) implementation.