- Notifications
You must be signed in to change notification settings - Fork1.1k
feat(agent): enable devcontainers by default#18533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
mafredri merged 2 commits intomainfrommafredri/feat-agent-enable-devcontainers-by-default-Jun 24, 2025
Merged
feat(agent): enable devcontainers by default#18533
mafredri merged 2 commits intomainfrommafredri/feat-agent-enable-devcontainers-by-default-Jun 24, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
9c8f951 to167122bCompareDanielleMaywood approved these changesJun 24, 2025
johnstcn approved these changesJun 24, 2025
99d124e intomain 33 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This change makes devcontainers default enabled.
Edit: The code paths that rely on Docker and
@devcontainers/cliwill log errors though, which is probably not ideal for someone who doesn't want devcontainers. I will think about a solution for that (but doesn't really have to be this PR).