Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: allow dynamic parameters to consider the prebuilds user an owner#18529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SasSwart merged 1 commit intomainfromjjs/dynamic-params-system-users
Jun 24, 2025

Conversation

SasSwart
Copy link
Contributor

@SasSwartSasSwart commentedJun 24, 2025•
edited
Loading

This Pull request allows dynamic parameters to list system users in its search for workspace owners. This is necessary to allow prebuilds to reconcile prebuilt workspaces and to delete them.

Copy link
Contributor

@ssncferreirassncferreira left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, might be worth checking with@Emyrk to confirm if this has any impact on dynamic parameters. There was a similar issue when deleting prebuilt workspaces from the CLI:https://github.com/coder/coder/pull/18333/files#r2158990408

@Emyrk
Copy link
Member

This is correct! My mistake.

@SasSwartSasSwart marked this pull request as ready for reviewJune 24, 2025 14:46
@SasSwartSasSwart merged commita4f1c64 intomainJun 24, 2025
40 checks passed
@SasSwartSasSwart deleted the jjs/dynamic-params-system-users branchJune 24, 2025 14:47
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 24, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ssncferreirassncferreirassncferreira approved these changes

@EmyrkEmyrkEmyrk approved these changes

Assignees

@SasSwartSasSwart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@SasSwart@Emyrk@ssncferreira
[8]ページ先頭
©2009-2025 Movatter.jp