- Notifications
You must be signed in to change notification settings - Fork925
fix: agentcontainers: fix flake when ctx cancelled while running docker inspect#18526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Other than the simplification suggestion, LGTM 👍🏻
Uh oh!
There was an error while loading.Please reload this page.
| @@ -378,7 +378,11 @@ func (api *API) updaterLoop() { | |||
| // and anyone looking to interact with the API. | |||
| api.logger.Debug(api.ctx, "performing initial containers update") | |||
| if err := api.updateContainers(api.ctx); err != nil { | |||
| api.logger.Error(api.ctx, "initial containers update failed", slog.Error(err)) | |||
| if errors.Is(err, context.Canceled) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Note thatcontext.Canceled doesn't, by default, trigger test failure. Still, nice to not pollute the error stream.
4066785 intomainUh oh!
There was an error while loading.Please reload this page.
Shouldfixcoder/internal#738