Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: update workspace table icons in WorkspacesTable#18525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 3 commits intomainfromcj/ui-workspace-table-update-icon
Jun 24, 2025

Conversation

@johnstcn
Copy link
Member

@johnstcnjohnstcn commentedJun 24, 2025
edited
Loading

Updates icons in WorkspacesTable to better differentiate between "start" and "update and start".

Note: the logic I'm currently using is as follows:

  • Workspace does not require active version and is outdated -> cloud icon
  • Workspace requires active version and is outdated -> circle play icon

I also, on a whim, updated the stories for the component to make the workspace names more identifiably reflect their content.

Screenshot 2025-06-24 at 11 49 17

Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

Perhaps a reviewer with artistic skills could also review this concept.

Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@johnstcnjohnstcnforce-pushed thecj/ui-workspace-table-update-icon branch froma67f5ed to6f902e0CompareJune 24, 2025 16:53
@johnstcnjohnstcn merged commit7070e47 intomainJun 24, 2025
28 checks passed
@johnstcnjohnstcn deleted the cj/ui-workspace-table-update-icon branchJune 24, 2025 18:24
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 24, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@dannykoppingdannykoppingdannykopping approved these changes

@mtojekmtojekmtojek approved these changes

@buenos-nachosbuenos-nachosAwaiting requested review from buenos-nachos

@DanielleMaywoodDanielleMaywoodAwaiting requested review from DanielleMaywood

+1 more reviewer

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@johnstcnjohnstcn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@johnstcn@dannykopping@BrunoQuaresma@mtojek

[8]ページ先頭

©2009-2025 Movatter.jp