- Notifications
You must be signed in to change notification settings - Fork924
chore: remove per request dynamic parameters opt in and rely on template#18505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedJun 23, 2025
MemberAuthor
Emyrk commentedJun 23, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This stack of pull requests is managed byGraphite. Learn more aboutstacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
Removes the per-request dynamic parameters opt-in and enforces the template’s default dynamic behavior.
- Deletes the
EnableDynamicParametersfields from SDK request types. - Strips out builder methods and conditional logic around dynamic parameters.
- Cleans up handler code in both workspace creation and build endpoints.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| codersdk/workspaces.go | Removed SDK field for dynamic parameters opt-in. |
| codersdk/organizations.go | Removed organizations SDK field for dynamic parameters. |
| coderd/wsbuilder/wsbuilder.go | Dropped builder field and method for dynamic parameters. |
| coderd/workspaces.go | Eliminated request branching onEnableDynamicParameters. |
| coderd/workspacebuilds.go | Cleaned up API handler logic related to dynamic parameters. |
Comments suppressed due to low confidence (5)
codersdk/workspaces.go:112
- The removal of
EnableDynamicParametersis a breaking SDK change; please update the SDK changelog and any public documentation to inform consumers about this removal.
TemplateVersionPresetID uuid.UUID `json:"template_version_preset_id,omitempty" format:"uuid"`codersdk/organizations.go:229
- Since this field is removed, ensure the API reference and migration guide note that
enable_dynamic_parametersis no longer supported on organization-related workspace creation.
TemplateVersionPresetID uuid.UUID `json:"template_version_preset_id,omitempty" format:"uuid"`coderd/wsbuilder/wsbuilder.go:58
- After removing the dynamic parameter field and methods, the
ptrpackage import may be unused; consider cleaning up any now-unused imports.
experiments codersdk.Experimentscoderd/workspacebuilds.go:385
- Similarly, ensure tests around the
postWorkspaceBuildshandler no longer referenceEnableDynamicParametersand properly reflect the new template-driven behavior.
builder = builder.State(createBuild.ProvisionerState)3e211f4 toe90251aCompareWhen in experimental this was used as an escape hatch. Removed to beconsistent with the template author's intentions
jaaydenh approved these changesJun 23, 2025
e90251a toa3f77b3Comparef6e4ba6 intomain 44 of 65 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
When in experimental this was used as an escape hatch. Removed to be
consistent with the template author's intentions
Backwards compatible, removing an experimental api field that is no longer used.