- Notifications
You must be signed in to change notification settings - Fork924
chore: update VPN proto to match additional types used by Coder Desktop#18504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I assume this is also going out in VPN RPC version 1.2?
We should also mention it inversion.go.
@johnstcn this field is already being used, but is windows specific and doesn't concern coderd, because only the vpn service and coder desktop use it. It's just hygiene to keep coder/coder a source of truth for the proto structure. |
OK, in that case it might be good to have additional context in the field comments and maybe a link? |
Uh oh!
There was an error while loading.Please reload this page.
Extends vpn.proto with DownloadProgress messages used by Coder Desktop on Windows.