- Notifications
You must be signed in to change notification settings - Fork1k
refactor: Update users page to looks like others#1850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| link?:string | ||
| } | ||
| exportconstAvatarData:React.FC<AvatarDataProps>=({ title, subtitle, link})=>{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I didn't find a better name for it 😓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Seems fine!
| "& .MuiSelect-root":{ | ||
| // Adjusting padding because it does not have label | ||
| paddingTop:theme.spacing(1.5), | ||
| paddingBottom:theme.spacing(1.5), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Added these because the select when there is no label is very BIG.
| } | ||
| constuseStyles=makeStyles((theme)=>({ | ||
| actions:{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is probably something we want to extract as well.
| link?:string | ||
| } | ||
| exportconstAvatarData:React.FC<AvatarDataProps>=({ title, subtitle, link})=>{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Seems fine!
| expect(rows).toHaveLength(MockBuilds.length) | ||
| // Wait for the results to be loaded | ||
| awaitwaitFor(async()=>{ |
BrunoQuaresmaMay 27, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not sure why, but this test should had fail before since it was "wrong"
Uh oh!
There was an error while loading.Please reload this page.
AvatarDatacomponent so we can keep it consistent between templates, workspaces, and users' views.