Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: implement efficient backend querying on the tasks page#18488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugodutka merged 1 commit intomainfromhugodutka/tasks-page-efficient-backend
Jun 24, 2025

Conversation

@hugodutka
Copy link
Contributor

@hugodutkahugodutka commentedJun 22, 2025•
edited
Loading

Use the/workspaces?q=has-ai-task=true,/templates?q=has-ai-task=true and/aitasks/prompts endpoints to fetch Task templates and workspaces on the/tasks page.

Also:

  • remove documentation link placeholders: the documentation is not in place yet and is not going to be available before the June 24th code freeze
  • load workspaces and templates in parallel
  • replace loading spinners with content skeletons

Related to#18454 andcoder/internal#660.

DANGER: this PR must be merged only after all issues mentioned in#18454 are closed to avoid breaking the dogfood environment.

@hugodutkahugodutkaforce-pushed thehugodutka/tasks-page-efficient-backend branch from3883a22 toc4d88d5CompareJune 22, 2025 17:36
@hugodutkahugodutka marked this pull request as ready for reviewJune 23, 2025 11:19
@hugodutkahugodutkaforce-pushed thehugodutka/tasks-page-efficient-backend branch fromc4d88d5 to4f403ddCompareJune 23, 2025 13:41
@hugodutkahugodutkaforce-pushed thehugodutka/bulk-wb-parameters branch 2 times, most recently from4b753a6 tof62da9dCompareJune 23, 2025 13:44
@hugodutkahugodutkaforce-pushed thehugodutka/tasks-page-efficient-backend branch from4f403dd to69a2e2dCompareJune 23, 2025 13:44
@hugodutkahugodutkaforce-pushed thehugodutka/bulk-wb-parameters branch fromf62da9d tof114f43CompareJune 23, 2025 13:47
@hugodutkahugodutkaforce-pushed thehugodutka/tasks-page-efficient-backend branch from69a2e2d to97a00baCompareJune 23, 2025 13:47
@hugodutkahugodutkaforce-pushed thehugodutka/bulk-wb-parameters branch fromf114f43 tobf23151CompareJune 23, 2025 14:52
@hugodutkahugodutkaforce-pushed thehugodutka/tasks-page-efficient-backend branch from97a00ba to604f994CompareJune 23, 2025 14:52
Copy link
Member

@code-ashercode-asher left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code looks good to me!

I tried it out and my template is not showing up in the dropdown and my workspace does not show in the table, but from my brief glance at the sql I think this is just because thehas_ai_task column is always false at the moment?

}catch(error){
constmessage=getErrorMessage(error,"Error creating task");
constdetail=getErrorDetail(error)??"Please, try again";
constdetail=getErrorDetail(error)??"Please try again";
Copy link
Member

@code-ashercode-asherJun 23, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Extremely minor, just noticing that this error message has no comma but the ones on 174 and 379 do. Personally I like it better without a comma.

hugodutka reacted with thumbs up emoji
/>
);
}
if(templates==null){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Also minor: I think the linter is fine with this, but everywhere else we do=== null (triple equals) or justif (templates).

hugodutka reacted with thumbs up emoji
@hugodutkahugodutkaforce-pushed thehugodutka/bulk-wb-parameters branch 2 times, most recently from1273e3c to5a42c7eCompareJune 24, 2025 10:52
Base automatically changed fromhugodutka/bulk-wb-parameters tomainJune 24, 2025 11:06
@hugodutkahugodutkaforce-pushed thehugodutka/tasks-page-efficient-backend branch from604f994 tob791c0aCompareJune 24, 2025 11:08
@hugodutkahugodutka merged commit1d2b96b intomainJun 24, 2025
26 of 28 checks passed
@hugodutkahugodutka deleted the hugodutka/tasks-page-efficient-backend branchJune 24, 2025 14:25
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 24, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@code-ashercode-ashercode-asher approved these changes

@BrunoQuaresmaBrunoQuaresmaAwaiting requested review from BrunoQuaresma

Assignees

@hugodutkahugodutka

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hugodutka@code-asher
[8]ページ先頭
©2009-2025 Movatter.jp