Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: throttle prebuild notifications#18483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@evgeniy-scherbina
Copy link
Contributor

@evgeniy-scherbinaevgeniy-scherbina commentedJun 20, 2025
edited
Loading

Closescoder/internal#674

Description:

  • Throttle notifications to template admins: send no more than one notification per 7 days.
  • Throttle notifications to template version author: send no more than one notification per 1 day.

Note:
It's done per template:

CREATETABLEtemplate_prebuild_notification_cooldowns (template_id UUIDNOT NULL,notification_typeTEXTNOT NULL,last_notification_sentTIMESTAMPTZNOT NULL,PRIMARY KEY (template_id, notification_type));

We can have multiple broken templates - in this case Template Admins will get one notification per template per 7 days.
I think it shouldn't be more than few notifications per week.

If it's still too noisy - we can consider making cooldowns global instead of template-specific. It should be enough to removetemplate_id field.

@evgeniy-scherbinaevgeniy-scherbinaforce-pushed theyevhenii/throttle-prebuild-notifications branch from92b5e63 to272c338CompareJune 20, 2025 20:06
@evgeniy-scherbinaevgeniy-scherbina changed the titlefix: throttle-prebuild-notificationsfix: throttle prebuild notificationsJun 20, 2025
@evgeniy-scherbinaevgeniy-scherbinaforce-pushed theyevhenii/throttle-prebuild-notifications branch fromae7135c tobd04330CompareJune 23, 2025 19:52
@evgeniy-scherbinaevgeniy-scherbinaforce-pushed theyevhenii/throttle-prebuild-notifications branch frombd04330 to362911eCompareJune 23, 2025 20:16
@evgeniy-scherbinaevgeniy-scherbina marked this pull request as ready for reviewJune 23, 2025 22:34
@dannykopping
Copy link
Contributor

I'mreally not a fan of this approach. It feels like we're just digging ourselves a deeper hole of technical debt instead of addressing the core issue.

We should move towards a daily or weekly summary email, like we have done for other build failures, and put logging and observability in place for operators to notice when problems occur with lower latency & greater resolution.

@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 24, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

No reviews

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reduce Notification Noise for Prebuild Failures

3 participants

@evgeniy-scherbina@dannykopping

[8]ページ先頭

©2009-2025 Movatter.jp