- Notifications
You must be signed in to change notification settings - Fork921
chore: update template opt-in checkbox#18481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
jaaydenh commentedJun 20, 2025
site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsForm.tsx OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
| @@ -230,21 +233,32 @@ export const TemplateSettingsForm: FC<TemplateSettingsForm> = ({ | |||
| size="small" | |||
| id="use_classic_parameter_flow" | |||
| name="use_classic_parameter_flow" | |||
| checked={form.values.use_classic_parameter_flow} | |||
| checked={!form.values.use_classic_parameter_flow} | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do we need to update the function that passes to the API to flip the value too? Like on the request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yes, good catch, we do because someone decided to use an inverted state for this setting. fixed. =)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
see the onchange below
579c851 intomainUh oh!
There was an error while loading.Please reload this page.