- Notifications
You must be signed in to change notification settings - Fork929
ci: cache embedded postgres downloaded binaries#18477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from2 commits
Commits
Show all changes
15 commits Select commitHold shift + click to select a range
f38ff28
ci: cache embedded postgres downloaded binaries
johnstcndc585db
log.fatal errors instead of panic
johnstcnf66007c
use step output for cache path
johnstcn8cfd0ff
Merge remote-tracking branch 'origin/cj/cache-embedded-postgres' into…
johnstcn0196ab6
praise log
johnstcn0e5366c
testing
johnstcn3d3aaaa
fix path
johnstcnd268942
use EMBEDDED_PG_CACHE_DIR
johnstcne6a7997
make embedded-pg less panicky
johnstcn4a27039
troubleshoot cache dir
johnstcn4c4f5e1
maybe this???
johnstcn9ec2b1b
fix upload cache destination
johnstcn1554d6b
also show file modtime
johnstcn5b81b29
i heart actionlint
johnstcn4d69612
ok this should work now
johnstcnFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
18 changes: 18 additions & 0 deletions.github/actions/embedded-pg-cache/action.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
name: "Upload Embedded Postgres Cache" | ||
description: Uploads the embedded Postgres cache. This only runs on the main branch. | ||
inputs: | ||
cache-key: | ||
description: "Cache key" | ||
required: true | ||
cache-path: | ||
description: "Path to the cache directory" | ||
required: true | ||
runs: | ||
using: "composite" | ||
steps: | ||
- name: Upload Embedded Postgres cache | ||
if: ${{ github.ref == 'refs/heads/main' }} | ||
uses: actions/cache/save@5a3ec84eff668545956fd18022155c47e93e2684 # v4.2.3 | ||
with: | ||
path: ${{ inputs.cache-path }} | ||
key: ${{ inputs.cache-key }} |
12 changes: 10 additions & 2 deletions.github/workflows/ci.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -497,12 +497,14 @@ jobs: | ||
# Create a temp dir on the R: ramdisk drive for Windows. The default | ||
# C: drive is extremely slow: https://github.com/actions/runner-images/issues/8755 | ||
mkdir -p "R:/temp/embedded-pg" | ||
mkdir -p "C:/temp/embedded-pg-cache" | ||
johnstcn marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
go run scripts/embedded-pg/main.go -path "R:/temp/embedded-pg" -cache "C:/temp/embedded-pg-cache" | ||
elif [ "${{ runner.os }}" == "macOS" ]; then | ||
# Postgres runs faster on a ramdisk on macOS too | ||
mkdir -p /tmp/tmpfs | ||
mkdir -p /tmp/embedded-pg-cache | ||
sudo mount_tmpfs -o noowners -s 8g /tmp/tmpfs | ||
go run scripts/embedded-pg/main.go -path /tmp/tmpfs/embedded-pg -cache /tmp/embedded-pg-cache | ||
elif [ "${{ runner.os }}" == "Linux" ]; then | ||
make test-postgres-docker | ||
fi | ||
@@ -571,6 +573,12 @@ jobs: | ||
with: | ||
cache-key: ${{ steps.download-cache.outputs.cache-key }} | ||
- name: Upload Embedded Postgres Cache | ||
uses: ./.github/actions/embedded-pg-cache | ||
with: | ||
cache-key: ${{ steps.download-cache.outputs.cache-key }} | ||
cache-path: ${{ runner.os == 'Windows' ? 'C:/temp/embedded-pg-cache' : '/tmp/embedded-pg-cache' }} | ||
johnstcn marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
- name: Upload test stats to Datadog | ||
timeout-minutes: 1 | ||
continue-on-error: true | ||
14 changes: 12 additions & 2 deletionsscripts/embedded-pg/main.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.