- Notifications
You must be signed in to change notification settings - Fork920
feat(dogfood/coder): add docker volume for... docker#18455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat(dogfood/coder): add docker volume for... docker#18455
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This change is in preparation for enabling devcontainers as well asallowing Docker image cache to be re-used across workspace restarts.For now, any running container will result in the retention of relatedresources (image, volumes, etc).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me! Just want to make sure though, do we have a plan for cleanup if these volumes start to get too large?
The current plan relies on the user not starting a container, and shutting down their workspace which will always clear everything. Likewise, if updated images are pulled, the old parts of that image will be pruned away on shutdown. |
68f21fa intomainUh oh!
There was an error while loading.Please reload this page.
If this becomes a problem, we can simply force deletion of all containers again. |
SGTM 👍🏻 |
Uh oh!
There was an error while loading.Please reload this page.
This change is in preparation for enabling devcontainers as well as
allowing Docker image cache to be re-used across workspace restarts.
For now, any running container will result in the retention of related
resources (image, volumes, etc).
Updatescoder/internal#463