Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: fix TestAcquireJob_LongPoll flake#18442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sreya merged 1 commit intomainfromjon/fixlongpoll
Jun 19, 2025
Merged

fix: fix TestAcquireJob_LongPoll flake#18442

sreya merged 1 commit intomainfromjon/fixlongpoll
Jun 19, 2025

Conversation

sreya
Copy link
Collaborator

@sreyasreya commentedJun 19, 2025•
edited
Loading

I'll be honest I'm not even really sure the point of this test but it was failing due to The intention appears to be to have the context expire due to the poll override as opposed to the context provided toAcquireJob

2025-06-16T15:01:54.0863251Z         Error:      Received unexpected error:2025-06-16T15:01:54.0863554Z                     acquire job:2025-06-16T15:01:54.0864230Z                         github.com/coder/coder/v2/coderd/provisionerdserver.(*server).AcquireJob2025-06-16T15:01:54.0865173Z                             /home/runner/work/coder/coder/coderd/provisionerdserver/provisionerdserver.go:3292025-06-16T15:01:54.0865683Z                       - failed to acquire job:2025-06-16T15:01:54.0866374Z                         github.com/coder/coder/v2/coderd/provisionerdserver.(*Acquirer).AcquireJob2025-06-16T15:01:54.0867262Z                             /home/runner/work/coder/coder/coderd/provisionerdserver/acquirer.go:1482025-06-16T15:01:54.0867819Z                       - pq: canceling statement due to user request

fixescoder/internal#714

The test was using a 1 microsecond timeout which is too short for databaseoperations, causing intermittent failures with 'pq: canceling statement dueto user request'. Increased to 10ms to allow sufficient time for the querywhile still testing the timeout behavior.
@sreyasreya requested a review fromdeansheatherJune 19, 2025 02:39
@sreyasreya requested review frommafredri and removed request fordeansheatherJune 19, 2025 02:39
@sreyasreyaenabled auto-merge (squash)June 19, 2025 02:42
@sreyasreya changed the titlefix: increase TestAcquireJob_LongPoll timeout to prevent flakinessfix: fix TestAcquireJob_LongPoll flakeJun 19, 2025
@sreyasreya merged commitb0fa327 intomainJun 19, 2025
42 checks passed
@sreyasreya deleted the jon/fixlongpoll branchJune 19, 2025 02:50
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 19, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@mafredrimafredriAwaiting requested review from mafredri

Assignees

@sreyasreya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flake: TestAcquireJob_LongPoll
2 participants
@sreya@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp