Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: check version.Err() after version.Next() in ConnectToPostgres#18437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugodutka merged 1 commit intomainfromhugodutka/version-next-pg-flake-fix
Jun 18, 2025

Conversation

hugodutka
Copy link
Contributor

@hugodutkahugodutka commentedJun 18, 2025•
edited
Loading

According toversion.Next's docstring:

Next prepares the next result row for reading with the [Rows.Scan] method. It returns true on success, or false if there is no next result row or an error happened while preparing it. [Rows.Err] should be consulted to distinguish between the two cases.

I locally reproduced the flake reported incoder/internal#672 and this PR should fix it.

@hugodutkahugodutka marked this pull request as ready for reviewJune 18, 2025 18:57
@hugodutkahugodutka requested a review fromsreyaJune 18, 2025 18:58
Copy link
Collaborator

@sreyasreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This will still result in an error right? So it's not fixing the underlying problem that's surfacing this flake.

@hugodutka
Copy link
ContributorAuthor

It'll surface the underlying context cancelled error. The test is configured to ignore it.

Copy link
Collaborator

@sreyasreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ahh i see

@hugodutkahugodutka merged commit4039327 intomainJun 18, 2025
40 checks passed
@hugodutkahugodutka deleted the hugodutka/version-next-pg-flake-fix branchJune 18, 2025 19:45
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 18, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@sreyasreyasreya approved these changes

Assignees

@hugodutkahugodutka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@hugodutka@sreya
[8]ページ先頭
©2009-2025 Movatter.jp