- Notifications
You must be signed in to change notification settings - Fork915
chore(agent): add workspace owner env var and log dev container app failures#18433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
8b87f6d toebd5ed7CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice, thanks!
Just one small request, please update the PR title to match the changes. 😄
agent/agentcontainers/subagent.go Outdated
| slog.F("field", appError.GetField()), | ||
| slog.F("error", appError.GetError()), | ||
| ) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just released this was on the client. I think it would be more impactful in the routine that injects the agent but at least this makes it visible.
Nevermind, that won't work since we don't have the field there 😅.
Since we're usinga.logger here, let's add someslog.Fs likeagent.Name and perhapsagent.ID?
Uh oh!
There was an error while loading.Please reload this page.
Listen to feedback that was missed in#18346
CODER_WORKSPACE_OWNER_NAMEinto the agent environment.