- Notifications
You must be signed in to change notification settings - Fork1k
fix: handle 'connection reset by peer' in postgres test utility#18423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add 'connection reset by peer' to the list of errors that should triggerstarting a new postgres container in the test utility. This fixes flakytests that fail when PostgreSQL resets connections.Fixes:coder/internal#695Co-authored-by: ibetitsmike <203725896+ibetitsmike@users.noreply.github.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the flaky PostgreSQL connection issue reported incoder/internal#695.
Problem
Tests were failing with "connection reset by peer" errors when trying to connect to PostgreSQL. The current error handling logic only recognized "connection refused" and "No connection could be made" as reasons to start a new postgres container, but didn't handle connection resets.
Solution
Added "connection reset by peer" to the list of error strings that should trigger starting a new postgres container in the test utility.
Testing
Fixescoder/internal#695