- Notifications
You must be signed in to change notification settings - Fork1.1k
feat: add app iframe controls#18421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fadbf77 to89c67d4Comparecode-asher commentedJun 18, 2025
Moved to draft, need to sort out some quirkiness with the scroll bar... |
code-asher commentedJun 18, 2025
Wait, sorry for all the pings, but turns out |
b7e7c0d to14674b4Comparecode-asher commentedJun 18, 2025
All right so unfortunately all we can actually add is a home button and a button to open in a new tab, but this is finally good to go. |
63b5f0b intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
I was not able to implement back/forward as we have no way of interacting with history in a cross-origin iframe.
The URL input was also a problem because there is no way to know if the cross-origin iframe's URL changes (due to a link inside the iframe for example), so it risks becoming stale.
In the future we can maybe do something where we serve our own HTML that sets up a message channel with the parent to communicate history changes, and then it replaces itself with the real content (similar to weno), or alternatively we munge the original content and inject our message channel code directly into it, although this will only work for apps we ourselves serve, nothing externally hosted will work this way.
fixes#18178