Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add app iframe controls#18421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
code-asher merged 2 commits intomainfrombq/iframe-controls
Jun 19, 2025
Merged

feat: add app iframe controls#18421

code-asher merged 2 commits intomainfrombq/iframe-controls
Jun 19, 2025

Conversation

@code-asher
Copy link
Member

@code-ashercode-asher commentedJun 17, 2025
edited by sreya
Loading

I was not able to implement back/forward as we have no way of interacting with history in a cross-origin iframe.

The URL input was also a problem because there is no way to know if the cross-origin iframe's URL changes (due to a link inside the iframe for example), so it risks becoming stale.

In the future we can maybe do something where we serve our own HTML that sets up a message channel with the parent to communicate history changes, and then it replaces itself with the real content (similar to weno), or alternatively we munge the original content and inject our message channel code directly into it, although this will only work for apps we ourselves serve, nothing externally hosted will work this way.

fixes#18178

@code-ashercode-asherforce-pushed thebq/iframe-controls branch 2 times, most recently fromfadbf77 to89c67d4CompareJune 18, 2025 00:14
@code-ashercode-asher removed the request for review fromBrunoQuaresmaJune 18, 2025 00:22
@code-ashercode-asher marked this pull request as draftJune 18, 2025 00:22
@code-asher
Copy link
MemberAuthor

Moved to draft, need to sort out some quirkiness with the scroll bar...

@code-ashercode-asher marked this pull request as ready for reviewJune 18, 2025 18:14
@code-asher
Copy link
MemberAuthor

Wait, sorry for all the pings, but turns outreload() is not accessible cross-origin either. 😢 Going to remove it.

@code-ashercode-asher removed the request for review fromBrunoQuaresmaJune 18, 2025 18:19
@code-ashercode-asher marked this pull request as draftJune 18, 2025 18:19
@code-ashercode-asherforce-pushed thebq/iframe-controls branch 2 times, most recently fromb7e7c0d to14674b4CompareJune 18, 2025 18:46
@code-asher
Copy link
MemberAuthor

All right so unfortunately all we can actually add is a home button and a button to open in a new tab, but this is finally good to go.

@code-ashercode-asher marked this pull request as ready for reviewJune 18, 2025 18:56
@code-ashercode-asher merged commit63b5f0b intomainJun 19, 2025
32 checks passed
@code-ashercode-asher deleted the bq/iframe-controls branchJune 19, 2025 17:22
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 19, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

1 more reviewer

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@code-ashercode-asher

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tasks: support refreshing a iFrame, home, and manually navigating

3 participants

@code-asher@BrunoQuaresma

[8]ページ先頭

©2009-2025 Movatter.jp