- Notifications
You must be signed in to change notification settings - Fork914
feat: migrate Alert component from MUI to shadcn#18412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
blink-so wants to merge1 commit intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Replace MUI Alert with shadcn-based implementation using class-variance-authority- Maintain backward compatibility with existing Alert API (severity, dismissible, actions, onDismiss)- Update AlertTitle imports across codebase to use new implementation- Add proper Tailwind CSS styling with dark mode support- Preserve accessibility features and smooth animations- Support all existing severity levels: info, success, warning, errorCo-authored-by: jaaydenh <1858163+jaaydenh@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the Alert component from MUI to shadcn implementation while maintaining full backward compatibility with the existing API.
Changes
Core Alert Component
class-variance-authorityseverity(info, success, warning, error)dismissiblefor showing dismiss buttonactionsfor custom action buttonsonDismisscallbackrole="alert"Updated Imports
Updated 6 files that were importing
AlertTitlefrom MUI to use our new implementation:ChangeWorkspaceVersionDialog.tsxProvisionerAlert.tsxGitDeviceAuth.tsxOverviewPageView.tsxWorkspace.tsxSetupPageView.tsxBenefits
Testing
The component maintains the exact same API as before, so all existing tests should continue to pass. The styling has been updated to use Tailwind classes with proper color variants for each severity level.
Files Changed
site/src/components/Alert/Alert.tsx- Main Alert component migrationsite/src/components/Alert/ErrorAlert.tsx- Updated importThis migration aligns with the project's move towards shadcn components and provides a more maintainable and customizable Alert system.