- Notifications
You must be signed in to change notification settings - Fork916
chore: update Go version to 1.24.4#18408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
- Update go.mod to use Go 1.24.4- Update dogfood/coder/Dockerfile GO_VERSION to 1.24.4- Update .github/actions/setup-go/action.yaml default version to 1.24.4- Update examples/parameters-dynamic-options/variables.yml to use golang:1.24- All Go version references are now consistent- Build tested successfully with Go 1.24.4Co-authored-by: sreya <4856196+sreya@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Needs to update flake.nix
| @@ -1,2 +1,2 @@ | |||
| go_image: "bitnami/golang:1.20-debian-11" | |||
| go_image: "bitnami/golang:1.24-debian-11" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lol
@deansheather Could you clarify what specific change is needed in flake.nix? Currently it's using Should I update to a different Nix package or make a different change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I guess ur right, thanks bro
Go ahead and merge it, blink |
nvm I guess you can't |
1a69338 intomainUh oh!
There was an error while loading.Please reload this page.
Updates all Go version references in the codebase to use Go 1.24.4.
Changes
go.modto use Go 1.24.4dogfood/coder/DockerfileGO_VERSION to 1.24.4.github/actions/setup-go/action.yamldefault version to 1.24.4examples/parameters-dynamic-options/variables.ymlto use golang:1.24Testing
scripts/check_go_versions.sh)