- Notifications
You must be signed in to change notification settings - Fork914
chore: use large modules in dogfood template#18389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Large modules can potentially break or slow down template behaviors.Our primary dogfood template should experience this if it becomesan issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I assume you've tested this already with a separate version of the dogfood template?
Yes sir! I made a version that uses this module and created/deleted a workspace. |
d562466 intomainUh oh!
There was an error while loading.Please reload this page.
| module "large-5mb-module" { | ||
| source = "git::https://github.com/Emyrk/large-module.git" | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This could be used to test our Terraform module caching proxy.
Uh oh!
There was an error while loading.Please reload this page.
Large modules can potentially break or slow down template behaviors. Our primary dogfood template should experience this if it becomes an issue.
Just trying to catch things in dogfood before we experience them in the wild.
Note: On
maintoday, you would never know this used to be a problem. I see no difference, and want to keep it that way.