Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add stop workspace button with confirmation dialog#18372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
matifali merged 6 commits intomainfromfeat/stop-workspace-button
Jun 18, 2025
Merged
Changes from1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
refactor: remove unused disabled prop from PrimaryAction
Remove the disabled prop from PrimaryActionProps interface andcomponent implementation since we now only use isLoading forbutton disabling.Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
  • Loading branch information
@blink-so@matifali
blink-so[bot] andmatifali committedJun 16, 2025
commitec096f810181e03f4ce34828fec608bd1cbe47c5
4 changes: 1 addition & 3 deletionssite/src/pages/WorkspacesPage/WorkspacesTable.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -610,14 +610,12 @@ const WorkspaceActionsCell: FC<WorkspaceActionsCellProps> = ({
type PrimaryActionProps = PropsWithChildren<{
label: string;
isLoading?: boolean;
disabled?: boolean;
onClick: () => void;
}>;

const PrimaryAction: FC<PrimaryActionProps> = ({
onClick,
isLoading,
disabled,
label,
children,
}) => {
Expand All@@ -629,7 +627,7 @@ const PrimaryAction: FC<PrimaryActionProps> = ({
variant="outline"
size="icon-lg"
onClick={onClick}
disabled={disabled ||isLoading}
disabled={isLoading}
>
<Spinner loading={isLoading}>{children}</Spinner>
<span className="sr-only">{label}</span>
Expand Down
Loading

[8]ページ先頭

©2009-2025 Movatter.jp