- Notifications
You must be signed in to change notification settings - Fork928
feat: add stop workspace button with confirmation dialog#18372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
6 commits Select commitHold shift + click to select a range
8e10cf7
feat: add stop workspace button with confirmation dialog
blink-so[bot]cb33963
feat: disable stop button during loading to prevent duplicate clicks
blink-so[bot]0d6032a
fix: remove unsupported loading prop from ConfirmDialog
blink-so[bot]b779d6f
fix: remove disabled prop from stop workspace button
blink-so[bot]a26067d
fix: remove empty line to fix biome formatting
blink-so[bot]ec096f8
refactor: remove unused disabled prop from PrimaryAction
blink-so[bot]File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
PrevPrevious commit
refactor: remove unused disabled prop from PrimaryAction
Remove the disabled prop from PrimaryActionProps interface andcomponent implementation since we now only use isLoading forbutton disabling.Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitec096f810181e03f4ce34828fec608bd1cbe47c5
There are no files selected for viewing
4 changes: 1 addition & 3 deletionssite/src/pages/WorkspacesPage/WorkspacesTable.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.