- Notifications
You must be signed in to change notification settings - Fork913
fix: show error message for incompatible parameters#18365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
| @@ -596,11 +596,18 @@ export const CreateWorkspacePageViewExperimental: FC< | |||
| const currentParameterValueIndex = | |||
| form.values.rich_parameter_values?.findIndex( | |||
| (p) => p.name === parameter.name, | |||
| ) ?? -1; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This feels like it could be a bad default 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yup, I removed this to check undefined instead
Need a docs update so this is clear to new users. |
dc5f69e intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
resolvescoder/preview#148
If there are any immutable params with diagnostics on the workspace parameters page, display this error dialog.