Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add ai tasks migrations#18359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugodutka merged 3 commits intomainfromhugodutka/ai-tasks-migrations
Jun 13, 2025
Merged

Conversation

hugodutka
Copy link
Contributor

@hugodutkahugodutka commentedJun 13, 2025
edited
Loading

Adds database migrations required for the Tasks feature.

There's a slight difference between the migrations in this PR and the RFC: this PR addsNOT NULL constraints to thehas_ai_task columns. It was an oversight on my part when I wrote the RFC - I assumed theDEFAULT FALSE value would make the columns implicitly NOT NULL, but that's not the case with Postgres. We have no use for the NULL value.

TheDEFAULT FALSE statement ensures that the migration will pass even when there are existing rows in the template version and workspace builds tables, so there's no danger in adding theNOT NULL constraints.

@hugodutkahugodutkaforce-pushed thehugodutka/ai-tasks-migrations branch from101e894 to2b15938CompareJune 13, 2025 12:57
@hugodutkahugodutka marked this pull request as ready for reviewJune 13, 2025 13:16
@@ -3355,6 +3355,7 @@ type TemplateVersion struct {
Message string `db:"message" json:"message"`
Archived bool `db:"archived" json:"archived"`
SourceExampleID sql.NullString `db:"source_example_id" json:"source_example_id"`
HasAiTask bool `db:"has_ai_task" json:"has_ai_task"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nit: can you use sqlc to correct the naming here toHasAITask?

hugodutka reacted with thumbs up emoji
@hugodutkahugodutkaforce-pushed thehugodutka/ai-tasks-migrations branch from2b15938 toe4e2035CompareJune 13, 2025 13:40
@hugodutkahugodutkaforce-pushed thehugodutka/ai-tasks-migrations branch frome4e2035 to50f1008CompareJune 13, 2025 13:41
Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚫[linkspector]reported byreviewdog 🐶
Cannot reachhttps://splunk.com Status: null Navigation timeout of 30000 ms exceeded

categorized using any log management tool such as[Splunk](https://splunk.com).

@hugodutkahugodutka merged commit8e29ee5 intomainJun 13, 2025
35 of 36 checks passed
@hugodutkahugodutka deleted the hugodutka/ai-tasks-migrations branchJune 13, 2025 13:54
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 13, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@dannykoppingdannykoppingdannykopping approved these changes

Assignees

@hugodutkahugodutka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@hugodutka@dannykopping

[8]ページ先頭

©2009-2025 Movatter.jp