- Notifications
You must be signed in to change notification settings - Fork911
feat(agent/agentcontainers): support apps for dev container agents#18346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
DanielleMaywood wants to merge5 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+445 −19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
d06023f to08f0f9cCompare08f0f9c to6270098CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR adds support for propagating user-defined apps (SubAgentApp) through the devcontainer workflow and into the agent API.
- Introduces
SubAgentAppand health-check definitions insubagent.goand includes them in create requests. - Extends
FakeAgentAPIto record and retrieve apps for end-to-end testing. - Updates the devcontainer CLI interface to accept environment variables and injects user/workspace context in
API.injectSubAgentIntoContainerLocked.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| agent/agenttest/client.go | AddsGetSubAgentApps and backing store in fake API |
| agent/agentcontainers/subagent.go | DefinesSubAgentApp, maps to proto request, includes in Create |
| agent/agentcontainers/subagent_test.go | Tests conversion ofSubAgentApp to proto in Create |
| agent/agentcontainers/devcontainercli.go | ExtendsReadConfig signature to accept env vars |
| agent/agentcontainers/devcontainercli_test.go | AdjustsReadConfig calls in tests |
| agent/agentcontainers/api.go | Injects apps and user/workspace name into sub-agent create |
| agent/agentcontainers/acmock/acmock.go | Updates mock signature forReadConfig |
Comments suppressed due to low confidence (2)
agent/agentcontainers/api.go:164
- The comment for
WithUserNameincorrectly states it sets the workspace name; it should say it sets the user name.
// WithUserName sets the workspace name for the sub-agent.agent/agentcontainers/subagent.go:27
- [nitpick] This exported type lacks a doc comment. Consider adding a comment above
SubAgentAppexplaining its purpose and fields.
type SubAgentApp struct {Uh oh!
There was an error while loading.Please reload this page.
fc5d9b9 tobacab01CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Add apps to the sub agent based on the dev container customization.
The implementation also provides the following env variables for use in the devcontainer json
CODER_AGENT_NAMECODER_USER_NAMECODER_WORKSPACE_NAMECODER_DEPLOYMENT_URL