- Notifications
You must be signed in to change notification settings - Fork924
chore: route connection logs to new table#18340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Requesting a draft review just to confirm we're happy with the DB schema, the RBAC setup, and the overall direction. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice work! I think this looks great in general, but the upsert part of the logic here doesn't fully make sense to me (see related comment). Could you elaborate on the intent?
return nil | ||
} | ||
func NewMock() *MockConnectionLogger { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggestion: This feels more like a "fake" than a "mock".
connection_logs | ||
LEFT JOIN users ON | ||
connection_logs.user_id = users.id | ||
LEFT JOIN users as workspace_owner ON |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LEFT JOIN usersas workspace_ownerON | |
LEFT JOIN usersAS workspace_ownerON |
-- limit of 100 to prevent accidental excessively large queries. | ||
COALESCE(NULLIF(@limit_opt :: int, 0), 100) | ||
OFFSET | ||
@offset_opt; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Note: Using limit/offset will get increasingly more slow as the table grows and you paginate further. First page will usually remain fast though.
Fine for now, though. Just raising awareness.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This is the first PR of a few for moving connection events out of the audit log, and into a new database table and web UI page called the 'Connection Log'.
This PR:
ConnectionLogger
abstraction to replace theAuditor
abstraction for these logs. (No-op'd in AGPL, like theAuditor
)ConnectionLogger
ConnectionLogger
instead of theAuditor
.Future PRs:
dbpurge
.Note
The PRs in this stack obviously won't be (completely) atomic. Whilst they'll each pass CI, the stack is designed to be merged all at once. I'm splitting them up for the sake of those reviewing, and so changes can be reviewed as early as possible. Despite this, it's really hard to make this PR any smaller than it already is. I'll be keeping it in draft until it's actually ready to merge.