- Notifications
You must be signed in to change notification settings - Fork912
feat: check for external auth before running task#18339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
3c8ae73
to324838d
Comparecode-asher commentedJun 12, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@bpmct I basically just ported over the external auth section from the create workspace page, except I only show the section if there is auth that needs to be connected. The run task button is disabled until authed. wdyt? recording.mp4 |
Works for me! |
tagging@BrunoQuaresma for a sanity check on the frontend |
I think we can have a better design for this, but I'm going to approve it for now since it is working as expected. In my head, the "Login with GitHub" should appear on the right side of the "select" to keep it close to its context. |
code-asher commentedJun 12, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yeah I think we can def have a better design, I just copied what was on the create workspace page lol One thing to keep in mind is there could be many login buttons (we only have two on dev.coder.com but in theory there could be an infinite number). Maybe we have a single "login" button that opens a dialog with all the external auth options. |
324838d
to750f4b6
CompareWe will use this on the tasks page.
It seems we do not validate external auth in the backend currently, so Iopted to do this in the frontend to match the create workspace page.
750f4b6
to8f021d0
CompareBTW, this seems related to#11367 |
bc74166
intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
It seems we do not validate external auth in the backend currently, so I opted to do this in the frontend to match the create workspace page.
Closes#18166