Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: check for external auth before running task#18339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
code-asher merged 2 commits intomainfromasher/tasks-external-auth
Jun 12, 2025

Conversation

code-asher
Copy link
Member

@code-ashercode-asher commentedJun 12, 2025
edited
Loading

It seems we do not validate external auth in the backend currently, so I opted to do this in the frontend to match the create workspace page.

Closes#18166

@code-ashercode-asher marked this pull request as draftJune 12, 2025 01:14
@code-ashercode-asherforce-pushed theasher/tasks-external-auth branch 2 times, most recently from3c8ae73 to324838dCompareJune 12, 2025 05:27
@code-asher
Copy link
MemberAuthor

code-asher commentedJun 12, 2025
edited
Loading

@bpmct I basically just ported over the external auth section from the create workspace page, except I only show the section if there is auth that needs to be connected. The run task button is disabled until authed. wdyt?

recording.mp4

@code-ashercode-asher marked this pull request as ready for reviewJune 12, 2025 05:35
@bpmct
Copy link
Member

Works for me!

@code-asher
Copy link
MemberAuthor

tagging@BrunoQuaresma for a sanity check on the frontend

@BrunoQuaresma
Copy link
Collaborator

I think we can have a better design for this, but I'm going to approve it for now since it is working as expected. In my head, the "Login with GitHub" should appear on the right side of the "select" to keep it close to its context.

code-asher reacted with thumbs up emoji

@code-asher
Copy link
MemberAuthor

code-asher commentedJun 12, 2025
edited
Loading

Yeah I think we can def have a better design, I just copied what was on the create workspace page lol

One thing to keep in mind is there could be many login buttons (we only have two on dev.coder.com but in theory there could be an infinite number). Maybe we have a single "login" button that opens a dialog with all the external auth options.

@code-ashercode-asherforce-pushed theasher/tasks-external-auth branch from324838d to750f4b6CompareJune 12, 2025 18:50
We will use this on the tasks page.
It seems we do not validate external auth in the backend currently, so Iopted to do this in the frontend to match the create workspace page.
@code-ashercode-asherforce-pushed theasher/tasks-external-auth branch from750f4b6 to8f021d0CompareJune 12, 2025 18:55
@matifali
Copy link
Member

BTW, this seems related to#11367

@code-ashercode-asher merged commitbc74166 intomainJun 12, 2025
75 of 77 checks passed
@code-ashercode-asher deleted the asher/tasks-external-auth branchJune 12, 2025 20:35
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 12, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@hugodutkahugodutkahugodutka approved these changes

@bpmctbpmctAwaiting requested review from bpmct

Assignees

@code-ashercode-asher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tasks: respect external-auth
5 participants
@code-asher@bpmct@BrunoQuaresma@matifali@hugodutka

[8]ページ先頭

©2009-2025 Movatter.jp