- Notifications
You must be signed in to change notification settings - Fork912
fix: resolve deletion pending badge text overflow#18296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
blink-so wants to merge1 commit intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+2 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Fixes#17927 by changing badge size from 'xs' to 'sm' in WorkspaceDormantBadgecomponent. The 'xs' size had insufficient padding (px-1.5) and height (h-5) toproperly contain the 'Deletion Pending' text, causing visual overflow.The 'sm' size provides adequate space with h-5.5 height and px-2 padding,consistent with other destructive variant badges in the codebase.Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#17927
Problem
The "Deletion Pending" status badge text was overflowing its container boundary due to insufficient space. The badge was using
size="xs"which provides onlypx-1.5padding andh-5height, causing the longer text to spill outside the badge.Solution
Changed the badge size from
xstosmfor both the "Deletion Pending" and "Dormant" badges in theWorkspaceDormantBadgecomponent. Thesmsize provides:h-5.5(instead ofh-5)px-2(instead ofpx-1.5)This change is consistent with other destructive variant badges in the codebase (e.g.,
DynamicParametercomponent).Testing
Screenshots
Before: Text overflows the red badge boundary
After: Text fits properly within the badge container