Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: resolve deletion pending badge text overflow#18296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
blink-so wants to merge1 commit intomain
base:main
Choose a base branch
Loading
fromfix/workspace-deletion-pending-badge-overflow

Conversation

blink-so[bot]
Copy link
Contributor

@blink-soblink-sobot commentedJun 9, 2025

Fixes#17927

Problem

The "Deletion Pending" status badge text was overflowing its container boundary due to insufficient space. The badge was usingsize="xs" which provides onlypx-1.5 padding andh-5 height, causing the longer text to spill outside the badge.

Solution

Changed the badge size fromxs tosm for both the "Deletion Pending" and "Dormant" badges in theWorkspaceDormantBadge component. Thesm size provides:

  • Increased height:h-5.5 (instead ofh-5)
  • More padding:px-2 (instead ofpx-1.5)

This change is consistent with other destructive variant badges in the codebase (e.g.,DynamicParameter component).

Testing

  • Verified the Badge component size definitions
  • Confirmed consistency with other similar components in the codebase
  • Both "Deletion Pending" and "Dormant" badges now use the same size for visual consistency

Screenshots

Before: Text overflows the red badge boundary
After: Text fits properly within the badge container

Fixes#17927 by changing badge size from 'xs' to 'sm' in WorkspaceDormantBadgecomponent. The 'xs' size had insufficient padding (px-1.5) and height (h-5) toproperly contain the 'Deletion Pending' text, causing visual overflow.The 'sm' size provides adequate space with h-5.5 height and px-2 padding,consistent with other destructive variant badges in the codebase.Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Deletion pending UI overflow
0 participants

[8]ページ先頭

©2009-2025 Movatter.jp