Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: improve JetBrains error message to mention Toolbox requirement#18294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
matifali merged 2 commits intomainfromfix/jetbrains-toolbox-error-message
Jun 18, 2025

Conversation

blink-so[bot]
Copy link
Contributor

@blink-soblink-sobot commentedJun 9, 2025•
edited by matifali
Loading

When users try to open JetBrains IDEs (GoLand, IntelliJ, etc.) without having JetBrains Toolbox installed, they now receive a more helpful error message that specifically mentions the Toolbox requirement instead of the generic "must be installed first" message.

Changes:

  • ModifieduseAppLink.ts to detect JetBrains apps by their protocol (jetbrains-gateway: orjetbrains:)
  • Updated error message for JetBrains apps to: "To use {app name}, you need to have JetBrains Toolbox installed."
  • Preserved existing error message for non-JetBrains apps

Testing:

  • Linting and TypeScript type checking pass
  • Code follows existing patterns and style

Addresses#17786

blink-sobotand others added2 commitsJune 9, 2025 20:12
When users try to open JetBrains IDEs (GoLand, IntelliJ, etc.) withouthaving JetBrains Toolbox installed, they now receive a more helpfulerror message that specifically mentions the Toolbox requirementinstead of the generic 'must be installed first' message.Fixes#17786Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Apply Biome formatter requirements for consistent code style.Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelJun 17, 2025
@matifalimatifali removed the staleThis issue is like stale bread. labelJun 18, 2025
@matifali
Copy link
Member

@kylecarbs I think this is a good enough workaround.

blink-so[bot] reacted with thumbs up emoji

Copy link
Member

@ParkreinerParkreiner left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks fine to me for a stopgap. There's a tiny bug here, where if the user switches to a different tab before the external app opens, the browser will treat that as the tool not being installed, even though everything's perfectly fine. But that's a bug that was here previously – I can go ahead and make an issue for that

matifali reacted with thumbs up emoji
@matifalimatifali merged commit2f59cd0 intomainJun 18, 2025
37 checks passed
@matifalimatifali deleted the fix/jetbrains-toolbox-error-message branchJune 18, 2025 14:34
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 18, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@matifalimatifalimatifali approved these changes

@ParkreinerParkreinerParkreiner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@matifali@Parkreiner
[8]ページ先頭
©2009-2025 Movatter.jp