Fix for Test Failures

I've identified and fixed the test failures in this PR. The issues were:

1.TestPatchTemplateMeta/ClassicParameterFlow

The test was expectingUseClassicParameterFlow to befalse by default, but the new migration (000334_dynamic_parameters_opt_out.up.sql) sets it totrue. I updated the test assertion to expect the correct default value.

2.TestDynamicParametersWithTerraformValues/RebuildParameters

The test was expecting dynamic parameters to work, but withuse_classic_parameter_flow now defaulting totrue, dynamic parameters are disabled by default. I updated the test setup to explicitly enable dynamic parameters by settingUseClassicParameterFlow tofalse for the test templates.

Changes Made:

• Updatedcoderd/templates_test.go line 1550 to expecttrue instead offalse
• Updatedcoderd/parameters_test.go to explicitly disable classic parameter flow in tests that require dynamic parameters
• Fixed variable shadowing issues introduced by the changes

The fix has been pushed to a separate branch:https://github.com/coder/coder/tree/pr-18290

These changes ensure the tests align with the new default behavior where templates opt out of dynamic parameters by default.

Additional Fix for wsbuilder Test Failure

I've fixed the additional test failure inTestWorkspaceBuildWithRichParameters/StartWorkspaceWithLegacyParameterValues.

The Issue:

The test was expectingGetTemplateVersionTerraformValues to be called (viawithTerraformValuesErrNoRows), but this call was not happening because the template hadUseClassicParameterFlow: true.

The Fix:

1. OptimizedusingDynamicParameters() function inwsbuilder.go:

   • Reordered the checks to avoid unnecessary database calls
   • Now checksUseClassicParameterFlow first before attempting to fetch terraform values
   • This is more efficient and prevents the test failure

2. Updated all affected tests inwsbuilder_test.go:

   • RemovedwithTerraformValuesErrNoRows expectations from tests wherewithTemplate setsUseClassicParameterFlow: true
   • This aligns the test expectations with the actual behavior

The changes ensure that when classic parameter flow is enabled, we don't make unnecessary database calls to fetch terraform values.