- Notifications
You must be signed in to change notification settings - Fork907
fix: preserve parameter values when dynamic ordering changes#18270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
blink-so wants to merge2 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+15 −2
Open
Changes fromall commits
Commits
Show all changes
2 commits Select commitHold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
17 changes: 15 additions & 2 deletionssite/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -608,7 +608,15 @@ export const CreateWorkspacePageViewExperimental: FC< | ||
| <div className="flex flex-col gap-9"> | ||
| {parameters.map((parameter, index) => { | ||
| const currentParameterValueIndex = | ||
| form.values.rich_parameter_values?.findIndex( | ||
| (p) => p.name === parameter.name, | ||
| ) ?? -1; | ||
| const parameterFieldIndex = | ||
| currentParameterValueIndex !== -1 | ||
| ? currentParameterValueIndex | ||
| : index; | ||
| const parameterField = `rich_parameter_values.${parameterFieldIndex}`; | ||
Comment on lines +611 to +619 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. @jaaydenh The overall approach looks correct to me. There might be some cleaner simplier syntax | ||
| const isPresetParameter = presetParameterNames.includes( | ||
| parameter.name, | ||
| ); | ||
| @@ -629,8 +637,13 @@ export const CreateWorkspacePageViewExperimental: FC< | ||
| return null; | ||
| } | ||
| // Get the form value by parameter name to ensure correct value mapping | ||
| const formValue = | ||
| currentParameterValueIndex !== -1 | ||
| ? form.values?.rich_parameter_values?.[ | ||
| currentParameterValueIndex | ||
| ]?.value || "" | ||
| : ""; | ||
| return ( | ||
| <DynamicParameter | ||
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.