Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: use spaces over tabs in proto files#18269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 1 commit intomainfromstevenmasley/proto_use_spaces
Jun 6, 2025

Conversation

Emyrk
Copy link
Member

No description provided.

@johnstcn
Copy link
Member

If we're worried about indentation, theprotobuf style guide says to use 2 spaces

@Emyrk
Copy link
MemberAuthor

If we're worried about indentation, theprotobuf style guide says to use 2 spaces

Oof, I'm just making this file consistent. Given it's at 4 spaces right now, I assume most people's editors are doing that.

I'll let it be someone else's problem later to change it to 2 lol. This is just bothering me

Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If we're going to ignore the style guide, let's do it consistently!

Emyrk reacted with laugh emoji
@EmyrkEmyrk merged commit348d19d intomainJun 6, 2025
36 checks passed
@EmyrkEmyrk deleted the stevenmasley/proto_use_spaces branchJune 6, 2025 14:11
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 6, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@spikecurtisspikecurtisAwaiting requested review from spikecurtisspikecurtis is a code owner

Assignees

@EmyrkEmyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Emyrk@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp