- Notifications
You must be signed in to change notification settings - Fork905
feat: increase maximum module files payload using proto streams#18268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Emyrk wants to merge22 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
What this does
Protobuf has a maximum message size, configured to4mb.
Dynamic parameters requires the remotely fetched module files located in
~/.terraform/modulesfor evaluation. These can exceed the maximum message size. To allow for templates with larger modules, this PR adds a proto stream to stream over the file in chunks. The resulting file is inserted to the database, and then referenced by filehash.Note every template version for a given template will have the same module_files (assuming no provider changes). So most module files are deduplicated per version. In the future, it might be even more advantageous to upload individual modules to reuse across various templates.
Implementation
Coderd <-> Provisionerd
If the
module_filesare too large, it uses a new protobuf stream to send and upload the file before theCompleteJobfires:coder/provisionerd/proto/provisionerd.proto
Lines 220 to 222 ine880894
The
CompleteJobreferences the file uploaded by itshashand its type.Provisionerd <-> Provisioner
This communication all happens in memory today right? No actual networks?
Since a
streamis already used,DataUploadandChunkPieceare added to the existing stream.