- Notifications
You must be signed in to change notification settings - Fork905
feat: add separate max token lifetime for administrators#18267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat: add separate max token lifetime for administrators#18267
Conversation
6214f1d
to4c418e6
CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'd like to see some tests for the inverse (shorter admin max token lifetime), as I could imagine security-conscious orgs wanting to minimize dangerous token lifetimes. There's also a potentially misleading comment. Apart from that, I don't need to review again.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
4c418e6
to9f15ef9
CompareUh oh!
There was an error while loading.Please reload this page.
Change-Id: I4540ce3eeb46ab58909ac37e60c3ece93668212aSigned-off-by: Thomas Kosiewski <tk@coder.com>
9f15ef9
toa8ea1f9
Comparef569d9c
intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Add separate token lifetime limits for administrators
This PR introduces a new configuration option
--max-admin-token-lifetime
that allows administrators to create API tokens with longer lifetimes than regular users. By default, administrators can create tokens with a lifetime of up to 7 days (168 hours), while the existing--max-token-lifetime
setting continues to apply to regular users.The implementation:
MaximumAdminTokenDuration
field to the session configurationThis change allows organizations to grant administrators extended token lifetimes while maintaining tighter security controls for regular users.
Fixes#17395