Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: port forwarding dropdown#1824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
code-asher wants to merge5 commits intomainfromasher/ports
Closed

feat: port forwarding dropdown#1824

code-asher wants to merge5 commits intomainfromasher/ports

Conversation

code-asher
Copy link
Member

@code-ashercode-asher commentedMay 27, 2022
edited
Loading

What this does:

  • Adds a web socket to the agent that scans for listening ports on an interval
  • Displays those ports in a popup when you open said popup
  • The popup also lets you manually open ports in case the detection is not working

Todo:

  • Fails on darwin, I think because thenetstat package does not support darwin. Not sure how to fix this yet.
  • Add comprehensive frontend test similar to the terminal test (only the individual parts are tested right now).
  • Probably need to filter out some ports like 22.
  • Not sure if the proxy backend is built out yet so the ports link to a temporary non-working URL right now.

Closes#1624

lame-demo-0006-2022-05-27_12.14.16.mp4

bpmct reacted with thumbs up emoji
@code-ashercode-asherforce-pushed theasher/ports branch 3 times, most recently froma911ed7 to63da850CompareMay 27, 2022 21:03
@ammario
Copy link
Member

What's the status of this feature?

@code-asher
Copy link
MemberAuthor

This is blocked on being able to actually open a link to a port. I messed up because I thought work on that was underway but it seems actually not to be? I was thinking I could just add it myself but I have not found the time to work on that yet.

IDK how we plan on doing the sub-domain version but since we already have/apps I imagine it would not be too much work to add a path-based version with a port number in it, something like/proxy/{port-number}.

@ammario
Copy link
Member

This is blocked on being able to actually open a link to a port. I messed up because I thought work on that was underway but it seems actually not to be? I was thinking I could just add it myself but I have not found the time to work on that yet.

I have no clue where the other work sits. Perhaps@tjcran can shed some light here. It's unfortunate to watch the ever-increasing merge conflicts erode this code. Dev URLs are a necessary feature for about half of our v1 users that are browser only.

IDK how we plan on doing the sub-domain version but since we already have/apps I imagine it would not be too much work to add a path-based version with a port number in it, something like/proxy/{port-number}.

Yeah, the wildcard subdomain setup always sucks. I think we all know the limitations of the path-based solution, but it could be an interesting fallback when the wildcard domain isn't setup yet. If we did that, we would want to make itvery clear_ to the user that they could setup a path-less solution.

@tjcran
Copy link

@ammario i believe@kylecarbs is doing the work for that. I'll let him comment.

@kylecarbs
Copy link
Member

That work is partially implemented by the#1773 PR. The wildcard subdomain routing and authentication still needs to be added. It's a bit of an awkward UX for our current setup experience, so I think we should align on how we'll do that before continuing. We can replicate the v1 experience, but it wasn't very smooth.

@kylecarbs
Copy link
Member

To clarify, this is fully blocked on me, not@code-asher!

@kylecarbs
Copy link
Member

This should stay open until we make headway on#2986. It'll certainly come into play!

@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelJul 29, 2022
@github-actionsgithub-actionsbot deleted the asher/ports branchFebruary 4, 2023 20:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
staleThis issue is like stale bread.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add link to open any port in dashboard
4 participants
@code-asher@ammario@tjcran@kylecarbs

[8]ページ先頭

©2009-2025 Movatter.jp