- Notifications
You must be signed in to change notification settings - Fork906
fix(cli): allow specifying empty provisioner tag set with --provisioner-tag="-"#18205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Minor suggestion for improving clarity, but otherwise LGTM! I think the- solution is a good compromise that fits well with existing behavior.
Uh oh!
There was an error while loading.Please reload this page.
da9a313 intomainUh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
post-merge approval
| @@ -80,6 +81,46 @@ func (r *RootCmd) templatePush() *serpent.Command { | |||
| createTemplate = true | |||
| } | |||
| var tags map[string]string | |||
| // Passing --provisioner-tag="-" allows the user to clear all provisioner tags. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice workaround 👍
Uh oh!
There was an error while loading.Please reload this page.
Relates to#17818
Note: due to limitations in
cobra/serpentI ended up having to use-to signify absence of provisioner tags. This value is not a valid key-value pair and thus not a valid tag.