- Notifications
You must be signed in to change notification settings - Fork905
fix: fix flashing error dialog in the create workspace page#18180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for fixing it 🙏 |
what if we did something like if(query.isError){return<ErrorAlerterror={query.error}/>;}if(!query.data){return<Loader/>;} so that we don't need to use the |
I suppose that works but looking at the react query docs, it feels like using isLoading/isPending is the straight-forward clearest way to do things,https://tanstack.com/query/latest/docs/framework/react/guides/queries |
aslilac commentedJun 2, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
but they don't give us the type safety that checking |
fd6981e
intomainUh oh!
There was an error while loading.Please reload this page.
This PR which updated react-query to 5.77.0 introduced an issue on the create workspace page where the error dialog would be briefly displayed while the page is loading.#18039
The issue is that there is a moment when
optOutQuery.isLoading
is false andoptOutQuery.data
is undefined causing the ErrorAlert to display.