Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: remove duplicated envbuilder vars#18144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ericpaulsen merged 2 commits intomainfromsharkymark-devcontainer-fix
Jun 3, 2025

Conversation

ericpaulsen
Copy link
Member

closes#18137

thelocals block in thekubernetes-devcontainer template contains duplicated environment variables which are already present in theenvbuilder_cached_image resource.

@ericpaulsenericpaulsen self-assigned thisMay 30, 2025
@ericpaulsenericpaulsen changed the titlefix: rm duplicated envbuilder varsfix: remove duplicated envbuilder varsMay 30, 2025
@ericpaulsenericpaulsenenabled auto-merge (squash)May 30, 2025 23:42
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I found that this breaks non-cached usage of the template:

2025-06-02 10:47:17.530 [warn]  Sending logs via AgentAPI v2  coder_version=v2.22.1+8708d81                                                                                                          envbuilder v1.1.0+a3a6a83 - Build development environments from repositories in a container                                                                                                          No Dockerfile specified, looking for a devcontainer.json...                                                                                                                                          Failed to locate devcontainer.json: open /workspaces/empty/.devcontainer: no such file or directory                                                                                                  Falling back to the default image...

We need to ensure thatENVBUILDER_GIT_URL gets passed to the container ifvar.cache_repo is empty.

@ericpaulsenericpaulsen merged commitb0d23ca intomainJun 3, 2025
33 of 34 checks passed
@ericpaulsenericpaulsen deleted the sharkymark-devcontainer-fix branchJune 3, 2025 15:24
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 3, 2025
@matifali
Copy link
Member

/cherry-pick release/2.23

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@matifalimatifaliAwaiting requested review from matifali

Assignees

@ericpaulsenericpaulsen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: example kubernetes-devcontainer template duplicates environment variable definitions for envbuilder
3 participants
@ericpaulsen@matifali@johnstcn

[8]ページ先頭

©2009-2025 Movatter.jp