thelocals block in thekubernetes-devcontainer template contains duplicated environment variables which are already present in theenvbuilder_cached_image resource.

fix: rm duplicated envbuilder env vars

64a85f0

ericpaulsen requested review fromjohnstcn andmatifali

May 30, 2025 23:14

ericpaulsen self-assigned this

May 30, 2025

ericpaulsen mentioned this pull request

May 30, 2025

bug: example kubernetes-devcontainer template duplicates environment variable definitions for envbuilder#18137

Closed

1 task

ericpaulsen changed the title~~fix: rm duplicated envbuilder vars~~fix: remove duplicated envbuilder vars

May 30, 2025

ericpaulsenenabled auto-merge (squash)

May 30, 2025 23:42

johnstcn reviewed

Jun 2, 2025

View reviewed changes

Copy link

Member

johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I found that this breaks non-cached usage of the template:

2025-06-02 10:47:17.530 [warn]  Sending logs via AgentAPI v2  coder_version=v2.22.1+8708d81                                                                                                          envbuilder v1.1.0+a3a6a83 - Build development environments from repositories in a container                                                                                                          No Dockerfile specified, looking for a devcontainer.json...                                                                                                                                          Failed to locate devcontainer.json: open /workspaces/empty/.devcontainer: no such file or directory                                                                                                  Falling back to the default image...

We need to ensure thatENVBUILDER_GIT_URL gets passed to the container ifvar.cache_repo is empty.