NotificationsYou must be signed in to change notification settings
Fork906
Star10k

fix(cli): handle nil unwrap errors when formatting#18099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ethanndickson merged 1 commit intomainfromethan/format-err-nil-unwrap-err

May 30, 2025

Merged

fix(cli): handle nil unwrap errors when formatting#18099

ethanndickson merged 1 commit intomainfromethan/format-err-nil-unwrap-err

May 30, 2025

Conversation

Copy link

Member

ethanndickson commentedMay 29, 2025•
edited
Loading

Discovered an unhelpful error when running a CLI command without internet (I didn't know I didn't have internet!):

$ coder lsEncountered an error running "coder list", see "coder list --help" for more informationerror: <nil>

The source of this was that callingUnwrap() onnet.DNSError can return nil, causing the whole error trace to get replaced by it. Instead, we'll just treat a nilUnwrap() return value as if there was nothing to unwrap.

The result is:

$ coder lsEncountered an error running "coder list", see "coder list --help" for more informationerror: query workspaces: Get "https://dev.coder.com/api/v2/workspaces?q=owner%3Ame": dial tcp: lookup dev.coder.com: no such host