- Notifications
You must be signed in to change notification settings - Fork1k
feat: add task page#18076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat: add task page#18076
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| // Open the web socket and hook it up to the terminal. | ||
| terminalWebsocketUrl( | ||
| proxy.preferredPathAppURL, | ||
| process.env.NODE_ENV!=="development" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What problem does this change solve? Please add a comment if this wasn't committed by mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Added comment.
| ...MockWorkspaceApp, | ||
| id:"cloud-code", | ||
| display_name:"Cloud Code", | ||
| icon:"https://uxwing.com/wp-content/themes/uxwing/download/brands-and-social-media/claude-ai-icon.png", |
hugodutkaMay 28, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We probably shouldn't use externally hosted images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We do this for many other storybook tests 😄 it has not been a problem so far
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Using/icons/claude.svg
| ...MockWorkspaceApp, | ||
| id:"cloud-code", | ||
| display_name:"Cloud Code", | ||
| icon:"https://uxwing.com/wp-content/themes/uxwing/download/brands-and-social-media/claude-ai-icon.png", | ||
| url:`${window.location.protocol}/iframe.html?viewMode=story&id=pages-terminal--ready&args=&globals=`, | ||
| external:true, | ||
| statuses:[ | ||
| MockWorkspaceAppStatus, | ||
| { | ||
| ...MockWorkspaceAppStatus, | ||
| id:"2", | ||
| message:"Planning changes", | ||
| state:"working", | ||
| }, | ||
| ], | ||
| }, | ||
| { | ||
| ...MockWorkspaceApp, | ||
| id:"vscode", | ||
| display_name:"VSCode", | ||
| icon:"/icon/code.svg", | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
| }, | ||
| latest_app_status:{ | ||
| ...MockWorkspaceAppStatus, | ||
| app_id:"cloud-code", | ||
| }, | ||
| }, | ||
| }); | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
typo: cloud-code -> claude-code
| {prompt} | ||
| </span> | ||
| <RouterLink | ||
| to={`/tasks/${workspace.owner_name}/${workspace.name}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
is there a risk that either owner_name or workspace name will contain url-incompatible characters and the resulting path will be invalid? or would RouterLink handle that internally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think it would handle that since we never had this problem before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah, owner_name here is the username, so there are no invalid characters allowed.
bc3b8d5 intomainUh oh!
There was an error while loading.Please reload this page.
Demo: