NotificationsYou must be signed in to change notification settings
Fork906
Star10k

chore: keep previous workspace build parameters for dynamic params#18059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Emyrk merged 8 commits intomainfromstevenmasley/previous_params

May 28, 2025

Merged

chore: keep previous workspace build parameters for dynamic params#18059

Emyrk merged 8 commits intomainfromstevenmasley/previous_params

May 28, 2025

Conversation

Copy link

Member

Emyrk commentedMay 27, 2025•
edited
Loading

The existing code persists all static parameters and their values. Using the previous build as the source if no new inputs are found.

Dynamic params do not have a state of the parameters saved to disk. So instead, all previous values are persisted always, and new inputs override.

Things like ephemeral params are not yet implemented in dynamic params, and will just always persist. Whereas in the past, they were repromtped. This needs to be resolved before GA. (tracked here:#17942)

github-actionsbot assignedEmyrk

May 27, 2025

Emyrk marked this pull request as ready for review

May 27, 2025 15:43

Emyrk commented

May 27, 2025

View reviewed changes

coderd/wsbuilder/wsbuilder.go Outdated

Comment on lines 640 to 657

		latestValues := make(map[string]string)
		for _, latest := range b.richParameterValues {
		latestValues[latest.Name] = latest.Value
		}

		// Merge the inputs with values from the previous build.
		for _, last := range lastBuildParameterValues {
		// TODO: Ideally we use the resolver here and look at parameter
		// fields such as 'ephemeral'. This requires loading the terraform
		// files. For now, just send the previous inputs as is.
		if _, exists := latestValues[last.Name]; exists {
		continue
		}
		names = append(names, last.Name)
		values = append(values, last.Value)
		}