Movatterモバイル変換

Skip to content

coder/coderPublic

NotificationsYou must be signed in to change notification settings
Fork909
Star10k

fix: handle invalid provisioning timings in ui#18058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

johnstcn merged 1 commit intomainfromcj/site/timings-handle-invalid

May 27, 2025

Merged

fix: handle invalid provisioning timings in ui#18058

johnstcn merged 1 commit intomainfromcj/site/timings-handle-invalid

May 27, 2025

Conversation

johnstcn

Copy link

Member

johnstcn commentedMay 27, 2025•
edited
Loading

Relates to#15432

Adds a storybook entry for zero values in provisioner timings.
Coerces a 'zero' start time to an 'instant'.
Improves timing chart handling for large timeframes. Previously, this would have caused the tab to run out of memory when encountering atime.Time{}.
Render 'instants' as 'invalid' in timing chart.

@johnstcn

fix: handle invalid provisioning timings in ui

c986426

@johnstcn

johnstcn requested review fromBrunoQuaresma andmtojek

May 27, 2025 13:49

@johnstcn

johnstcn self-assigned this

@johnstcn

johnstcn mentioned this pull request

agent connection timings rendering as negative values when agent cannot connect#15432

Closed

BrunoQuaresma

BrunoQuaresma approved these changes

View reviewed changes

@johnstcn

johnstcn merged commitce134bc intomain

37 checks passed

@johnstcn

johnstcn deleted the cj/site/timings-handle-invalid branch

May 27, 2025 14:10

@github-actions

github-actionsbot locked and limited conversation to collaborators

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Labels

None yet

2 participants

@johnstcn

@BrunoQuaresma

[8]ページ先頭

©2009-2025 Movatter.jp