Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(coderd/database): enforce agent name unique within workspace build#18052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
DanielleMaywood merged 13 commits intomainfromdm-workspace-agent-name-uniqueness
May 28, 2025

Conversation

DanielleMaywood
Copy link
Contributor

@DanielleMaywoodDanielleMaywood commentedMay 27, 2025•
edited
Loading

This PR creates a database trigger that runs on insert and update of theworkspace_agents table. The trigger ensures that the agent name is unique within the context of the workspace build it is being inserted into.

@DanielleMaywoodDanielleMaywoodforce-pushed thedm-workspace-agent-name-uniqueness branch from053251c to2aadf9fCompareMay 27, 2025 14:19
@DanielleMaywoodDanielleMaywood marked this pull request as ready for reviewMay 27, 2025 14:20
@DanielleMaywoodDanielleMaywood changed the titlechore(coderd/database): create db trigger to enforce agent name is uniquechore(coderd/database): enforce agent name unique within workspace resourceMay 27, 2025
…enessThis PR creates a new database trigger to ensure an inserted workspaceagent has a unique name within the scope of its workspace.
Child agents are a new concept so there are very little existing testsfor them. This means we can easily make the change for them withouthaving to update a mountain of tests. So they get a special case forchecking properly, whilst parent agents have less scrutiny due to thevast number of tests that appear to not work properly.
@DanielleMaywoodDanielleMaywoodforce-pushed thedm-workspace-agent-name-uniqueness branch fromc331dca toe51c8beCompareMay 27, 2025 15:00
The CI will fail for this as there are test failures for insights.
@DanielleMaywoodDanielleMaywood changed the titlechore(coderd/database): enforce agent name unique within workspace resourcechore(coderd/database): enforce agent name unique within provisioner jobMay 27, 2025
@DanielleMaywoodDanielleMaywood changed the titlechore(coderd/database): enforce agent name unique within provisioner jobchore(coderd/database): enforce agent name unique within workspace buildMay 28, 2025
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Minor suggestions but otherwise looking good, nice job!

- add a comment on trigger- spaces to tabs
@DanielleMaywoodDanielleMaywood merged commit6e255c7 intomainMay 28, 2025
34 checks passed
@DanielleMaywoodDanielleMaywood deleted the dm-workspace-agent-name-uniqueness branchMay 28, 2025 13:21
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 28, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather left review comments

@mafredrimafredrimafredri approved these changes

@EmyrkEmyrkAwaiting requested review from Emyrk

Assignees

@DanielleMaywoodDanielleMaywood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@DanielleMaywood@mafredri@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp