- Notifications
You must be signed in to change notification settings - Fork905
fix!: update WorkspaceOwnerName to use user.name instead of user.username#18025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We should go ahead and just addname to all the views imo. 👍
| COALESCE( | ||
| visible_users.avatar_url, | ||
| ''::text | ||
| ) AS initiator_by_avatar_url, | ||
| COALESCE( | ||
| visible_users.username, | ||
| ''::text | ||
| ) AS initiator_by_username |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should we include thename here too now?
| COALESCE( | ||
| visible_users.avatar_url, | ||
| ''::text | ||
| ) AS created_by_avatar_url, | ||
| COALESCE( | ||
| visible_users.username, | ||
| ''::text | ||
| ) AS created_by_username, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Name here too now?
| COALESCE( | ||
| visible_users.avatar_url, | ||
| ''::text | ||
| ) AS created_by_avatar_url, | ||
| COALESCE( | ||
| visible_users.username, | ||
| ''::text | ||
| ) AS created_by_username |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Name here too now?
@Emyrk good catches! |
d63417b intomainUh oh!
There was an error while loading.Please reload this page.
We have been using the user.username instead of user.name in wrong places, making it very confusing for the UI.