Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: group apps together on workspace page#18018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 2 commits intomainfromlilac/app-groups-frontend
May 29, 2025

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedMay 23, 2025
edited
Loading

Closes#8237

Screenshot 2025-05-27 at 5 50 43 PM

Base automatically changed fromlilac/app-groups tomainMay 27, 2025 19:13
@aslilacaslilac requested a review fromjaaydenhMay 27, 2025 23:51
@aslilacaslilac marked this pull request as ready for reviewMay 27, 2025 23:51
@aslilacaslilac marked this pull request as draftMay 27, 2025 23:51
@jaaydenh
Copy link
Contributor

@aslilac Left some comments, didn't approve yet because its still marked as draft. It would be useful to add a storybook test to be able to easily visualize the change.

@aslilacaslilac marked this pull request as ready for reviewMay 28, 2025 19:46
@aslilac
Copy link
MemberAuthor

sorry about that, I realized it wasn't actually ready after I tagged you and marked it as ready 🤦‍♀️ it should actually be ready to go now

@matifali
Copy link
Member

Can we set up an icon for the group, too?

@aslilac
Copy link
MemberAuthor

aslilac commentedMay 29, 2025
edited
Loading

that was never discussed in the design ticket, and would require more terraform provider and backend changes 😅

matifali reacted with laugh emoji

@matifali
Copy link
Member

matifali commentedMay 29, 2025
edited
Loading

The next step would be to group all the IDEs we have in dogfood. It will be interesting to support this while our IDEs come from modules.

@aslilac
Copy link
MemberAuthor

I don't think we should group IDEs, I think we should use them to dogfood dynamic parameters.

but we should have all of the modules take agroup input so that others can configure it that way if they want to.

matifali reacted with thumbs up emoji

@aslilacaslilacforce-pushed thelilac/app-groups-frontend branch frome611845 toc200325CompareMay 29, 2025 17:28
@aslilacaslilacforce-pushed thelilac/app-groups-frontend branch fromc200325 to685848dCompareMay 29, 2025 17:28
@aslilacaslilac merged commit232c72f intomainMay 29, 2025
33 checks passed
@aslilacaslilac deleted the lilac/app-groups-frontend branchMay 29, 2025 18:01
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 29, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@jaaydenhjaaydenhjaaydenh approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create nested app buttons like the helper apps
3 participants
@aslilac@jaaydenh@matifali

[8]ページ先頭

©2009-2025 Movatter.jp