Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add hard-limited presets metric#18008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
evgeniy-scherbina merged 11 commits intomainfrom17988-metric-for-hard-limited-presets
May 26, 2025
Merged
Changes from1 commit
Commits
Show all changes
11 commits
Select commitHold shift + click to select a range
6fb6800
feat: add hard-limited presets metric
evgeniy-scherbinaMay 22, 2025
a1a4f2a
fix: report metric only for active template version
evgeniy-scherbinaMay 23, 2025
2667684
fix: hard-limiting should only apply to creation of prebuilds
evgeniy-scherbinaMay 23, 2025
6a14a8b
test: improve test coverage for hard-limited presets
evgeniy-scherbinaMay 23, 2025
0882626
fix: make fmt
evgeniy-scherbinaMay 23, 2025
1c53074
refactor: improve documentation
evgeniy-scherbinaMay 23, 2025
3100e01
test: improve testing coverage
evgeniy-scherbinaMay 23, 2025
80c89fe
refactor: CR's fixes
evgeniy-scherbinaMay 26, 2025
1b9593b
fix: fix tests & linter
evgeniy-scherbinaMay 26, 2025
2a8e11b
Merge remote-tracking branch 'origin/main' into 17988-metric-for-hard…
evgeniy-scherbinaMay 26, 2025
00a2fcb
Update metric description
evgeniy-scherbinaMay 26, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
fix: report metric only for active template version
  • Loading branch information
@evgeniy-scherbina
evgeniy-scherbina committedMay 23, 2025
commita1a4f2a2a7b1be28b3d93228183ccf6f7df1e618
4 changes: 3 additions & 1 deletionenterprise/coderd/prebuilds/reconcile.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -361,7 +361,9 @@ func (c *StoreReconciler) ReconcilePreset(ctx context.Context, ps prebuilds.Pres
slog.F("preset_name", ps.Preset.Name),
)

c.metrics.trackHardLimitedStatus(ps.Preset.OrganizationName, ps.Preset.TemplateName, ps.Preset.Name, ps.IsHardLimited)
if !ps.Preset.Deleted && ps.Preset.UsingActiveVersion {
c.metrics.trackHardLimitedStatus(ps.Preset.OrganizationName, ps.Preset.TemplateName, ps.Preset.Name, ps.IsHardLimited)
}

// If the preset was previously hard-limited, log it and exit early.
if ps.Preset.PrebuildStatus == database.PrebuildStatusHardLimited {
Expand Down
Loading

[8]ページ先頭

©2009-2025 Movatter.jp